Repository navigation
Conversation
d935940 to
eee5353
Compare
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eee5353330
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9de42e92b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6679091351
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8b34945 to
9d08b6d
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d08b6def9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62498806e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| continue-on-error: true | ||
| run: | | ||
| file=config/oxlint/oxlint.seatbelt.tsv | ||
| [ "$(git ls-remote origin main | cut -f1)" = "$GITHUB_SHA" ] || { echo "::notice::main moved, skipping"; exit 0; } |
There was a problem hiding this comment.
Make the main-head check atomic with the baseline PUT
If another push advances main after this check but before the PUT, the request still writes to branch=main; its sha is HEAD:$file, and gh api --help defines --field as “Add a typed parameter in key=value format,” not a precondition on the branch ref. The stale run can therefore lower the baseline beneath diagnostics added by the concurrent push; its bot push is skipped, while that push's run can already have checked out its event SHA and skip saving after seeing the bot commit, leaving subsequent main lint failing. Use an atomic ref compare-and-swap or re-lint the latest main before writing. Fresh evidence: this change adds only a separate preflight ls-remote, so the interval before the PUT remains racy.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Yes, there is a small window between the check and the PUT. The gap is about few seconds probably, and the closest merges to main in the recent run history were about two minutes apart, so closing it probably isn’t worth the extra code. If it ever happens, main goes red and the fix is to raise the baseline. EApp avoids it with git push, which needs secrets Onyx doesn’t have yet, so I would skip this case
roryabraham
left a comment
There was a problem hiding this comment.
Otherwise all LGTM 👍🏼
| concurrency: ${{ github.workflow }} | ||
|
|
||
| jobs: | ||
| lint: |
There was a problem hiding this comment.
Not sure we need to lint in publish if we weren't before?
Details
Moves Onyx's linting from ESLint to Oxlint, using the rules from
eslint-config-expensify4.0.21.oxlint.config.mtsbuilds the config from the package presets withbuildOxlintConfig()(Expensify/eslint-config-expensify#214) and adds only Onyx's own ignores, settings and overrides. No rules are copied here.eslint.config.mjsis removed andnpm run lintruns Oxlint 1.92 with type-aware rules. The ESLint packages stay installed because the presets and those rules need them.config/oxlint/oxlint.seatbelt.tsv, the same setup as in E/App. New errors fail CI and fixing errors lowers the allowed count.lint.ymlruns on pull requests and is called bypublish.ymlon push tomain, so a failing lint blocks publishing. If the merge fixed baselined errors, that run commits the lowered baseline as os-botify before the version bump. This only runs on a real push tomain, so it is untested until the first merge.tsconfig.jsonusesmoduleResolution: bundlerbecause type-aware Oxlint rejectsnode.tsconfig.build.jsonand.github/actions/javascript/tsconfig.jsonkeep CommonJS, so the build output is unchanged.lib/only has comment updates and drops an unusedreact-native-nitro-sqlite/mocktype declaration.Parity with ESLint, measured before ESLint was removed: all 665 Oxlint findings match ESLint's. ESLint reported 48 more: 47
rulesdir/prefer-at(Oxlint usesunicorn/prefer-at) and 1no-unnecessary-type-assertion.Related Issues
Expensify/App#105688
Linked E/App PR
Expensify/App#107001
Automated Tests
config/oxlint/seatbelt.test.mjs: 9 tests for the seatbelt ratchet (npm run test:lint, added to the test workflow).test:typespass unchanged.Manual Tests
[No QA]: lint tooling only, no runtime changes. Local checks:
npm ci, thennpm run lint: prints0 errors.console.log('test');tolib/utils.tsand runnpm run lint: fails withno-console. Revert.config/oxlint/oxlint.seatbelt.tsv, raise one row's count by 1 and runCI=true npm run lint: passes and rewrites the row back to the real count (what themainjob commits). Revert.npm run test:lint: 9 tests pass.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A, no UI or runtime changes.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari