Skip to content

Adopt Oxlint for react-native-onyx #105688

Open

Description

@roryabraham

Now that Expensify/App uses Oxlint instead of ESLint, let's upgrade react-native-onyx as well for consistency and a better DX.

Issue OwnerCurrent Issue Owner: @LukasMod

Activity

  1. melvin-bot commented on Nov 5, 2026

    @melvin-bot

    @LukasMod Whoops! This issue is 2 days overdue. Let's get this updated quick!

  2. LukasMod commented on Nov 6, 2026

    @LukasMod
    Contributor

    Working on Expensify/react-native-onyx#889

    • Upgrade eslint-config-expensify to the latest version (v2 to v4)
    • Set up Oxlint
    • Add seatbelt
    • Add a CI step that auto-tightens the seatbelt baseline
    • all 665 Oxlint findings matched ESLint; ESLint had 48 more (47 prefer-at, 1 no-unnecessary-type-assertion)
  3. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @LukasMod Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    @LukasMod Huh... This is 4 days overdue. Who can take care of this?

  5. roryabraham commented on Nov 11, 2026

    @roryabraham
    ContributorAuthor

    @LukasMod is OOO today

  6. LukasMod commented on Nov 13, 2026

    @LukasMod
    Contributor

    I'm trying to first prepare: Expensify/eslint-config-expensify#214, which already is used in Draft Expensify/react-native-onyx#889 as PoC, same for EApp

  7. LukasMod commented on Nov 16, 2026

    @LukasMod
    Contributor

    @roryabraham Expensify/react-native-onyx#889 is ready for review.

    • it moves Onyx to Oxlint using the eslint-config-expensify presets
    • adds a seatbelt baseline for the existing errors, the same as in EApp
    • baseline should tightens itself on main (before publish)

    I couldn’t verify the auto-tighten CI part yet, because it only runs on a real push to main. To avoid racing with publish, lint.yml is now called from publish.yml first, so the baseline commit lands before the version bump. A failing lint on main therefore blocks publishing, which I think its a good thing

    The final test would be next PR that fixes something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions