Repository navigation
Conversation
42 tasks done
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Companion PR for react-native-onyx PR #889, which moves Onyx linting from ESLint to Oxlint. It pins
react-native-onyxto that PR's HEAD viagit+https, so E/App CI runs against the change before the Onyx PR merges and publishes.Pin:
"react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#62498806e4828ea1e1b9d4833c16972ad26e159a".This also brings E/App from Onyx 3.0.143 to the Onyx main it was last merged with (3.0.155).
Not for merge as is. Once Onyx PR #889 merges and publishes, I'll repin to the released version (for example
"react-native-onyx": "3.0.xx"), and this becomes the bump PR.Fixed Issues
$ #105688
PROPOSAL:
Tests
This is a library bump with no user-facing UI change. The goal is to confirm no regressions in normal Onyx read and write behavior through E/App CI.
npm installandnpm run web.Offline tests
QA Steps
Same as tests. There are no user-facing behavior changes. This is an Onyx library bump for CI verification.