Skip to content

[No QA] [Test] Pin react-native-onyx to #889 (Oxlint) - #107001

Draft
LukasMod wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:LukasMod/pin-onyx-889-oxlint
Draft

LukasMod wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:LukasMod/pin-onyx-889-oxlint

Conversation

@LukasMod

Copy link
Copy Markdown
Contributor

Explanation of Change

Companion PR for react-native-onyx PR #889, which moves Onyx linting from ESLint to Oxlint. It pins react-native-onyx to that PR's HEAD via git+https, so E/App CI runs against the change before the Onyx PR merges and publishes.

Pin: "react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#62498806e4828ea1e1b9d4833c16972ad26e159a".

This also brings E/App from Onyx 3.0.143 to the Onyx main it was last merged with (3.0.155).

Not for merge as is. Once Onyx PR #889 merges and publishes, I'll repin to the released version (for example "react-native-onyx": "3.0.xx"), and this becomes the bump PR.

Fixed Issues

$ #105688
PROPOSAL:

Tests

This is a library bump with no user-facing UI change. The goal is to confirm no regressions in normal Onyx read and write behavior through E/App CI.

  1. Run npm install and npm run web.
  2. Log in and use the app normally (open chats and reports, create an expense, switch workspaces).
  3. Verify data loads and persists across reloads as before.
  4. Verify no new JS console errors appear during normal use.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and perform actions that write to Onyx (for example, draft a message or create an expense). Verify optimistic data is stored and the UI updates as expected.
  2. Go back online and verify the queued changes sync normally.

QA Steps

Same as tests. There are no user-facing behavior changes. This is an Onyx library bump for CI verification.

  • Verify that no errors appear in the JS console

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant