Repository navigation
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@MelvinBot review |
9cce576 to
bd549ef
Compare
|
@MelvinBot review |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable findings in the static review. Checked preset migration, rule aliases, ESLint directives, React Compiler gating, and CLI/LSP integration. CI lint, typecheck, and tests pass. Local runtime checks were blocked by execution permissions, so config loading wasn’t independently verified. Independent peer approval is still outstanding. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@nkdengineer Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
nkdengineer
left a comment
There was a problem hiding this comment.
The change looks good. Just a small comment.
| plugins: ['typescript', 'import', 'jsx-a11y', 'unicorn', 'react'], | ||
| // oxlint reserves `react`, `import` and `jsdoc` for its native ports, so jsPlugins use these aliases. | ||
| export default await buildOxlintConfig({ | ||
| withNursery: true, |
There was a problem hiding this comment.
Nursery rules are oxlint's unstable tier, so an oxlint bump can change what they report. Add one line on why it's needed, presumably because some preset rules only exist as nursery rules, and ideally which rules those are
Explanation of Change
oxlint.config.mtsrepeated theeslint-config-expensifyrules by hand. This PR builds them from the package instead, withbuildOxlintConfig()from Expensify/eslint-config-expensify#214, so rule changes come from bumpingeslint-config-expensifyand need no edits here. Expensify/react-native-onyx#889 does the same for Onyx.oxlint.config.mtslists the presets the App uses (browser, react, expensify, typescript, scripts, jest, prettier) and keeps only the App's own config: ignores, env, globals, settings, plugins and rules.hostedandrulesdirplugins on top of the package's: they add the React Compiler gate on three rules, the App's local rules and the App-only hosted rules (config/oxlint/appHostedRules.mjs). React Compiler rules still run asrc/.oxlint.config.mtswith the same rules, severities and files as before. They run fromeslint-plugin-storybookasstorybook/<name>, so a plugin upgrade doesn't add rules by itself.oxlint.config.mtsnames a rule as ESLint spells it although it runs ascore/orhosted/. Other wrong names fail with oxlint's own error.config/oxlint/eslintDirectives.mjsandplugins/core-rules.mjs(now in the package), and theeslint-config-expensifyTypeScript 6 patch, which nothing loads any more (the two rules that used it are left out of the oxlint plugin).eslint-config-expensify4.0.21, the release that includes #214.Also:
@oxlint/migrate1.92.0 as a dev dependency, matchingoxlint1.92.0. The package uses it to convert the presets.eslint-plugin-jsdocdev dependency: the package brings it forhosted/require-jsdoc.contributingGuides/LINTING.mdexplains where the rules come from and how to add one, with an example for each case.Parity. Two checks against
main:npm run lintpasses on the whole repo, and so doesSEATBELT_FROZEN=1 npm run lint, which fails on any per-file, per-rule error count that changes in either direction. So the errors found are the same as with the old config.dot-notation,import/order,import/no-cycle,jsx-a11y/anchor-has-content,no-undef.mtsfiles,@typescript-eslint/no-deprecatednow runs andno-unexpected-multilineis off, as under ESLintreact/jsx-uses-reactandreact/jsx-uses-varsno longer run: they only mark variables as used, and oxlint'sno-unused-varsalready handles JSX (same reports with and without them)no-unused-varsgetsreportVarsOnlyUsedAsTypeson TypeScript files, as in ESLintno-new-object/no-new-symbolrun as ESLint's core rules, instead of oxlint's versionsstorybook/<name>instead ofhosted/<name>, with the same severities and filesCost. Building the config takes about 0.7 s each time oxlint loads it (up to about 2 s on a cold first run).
npm run lintpays it once in the wrapper and once per JS plugin shard, in parallel.Fixed Issues
$ #106151
PROPOSAL:
Tests
Offline tests
N/A, lint config only.
QA Steps
[No QA]: lint config only, no app code changes.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A, lint config only.
Android: mWeb Chrome
N/A, lint config only.
iOS: Native
N/A, lint config only.
iOS: mWeb Safari
N/A, lint config only.
MacOS: Chrome / Safari
N/A, lint config only.