Repository navigation
fix: keep the project folder inside the current directory - #102
Merged
Merged
Conversation
This was referenced Oct 31, 2026
msmps
force-pushed
the
fix/project-path-safety
branch
from
October 31, 2026 21:24
fd3f748 to
e7867b7
Compare
msmps
force-pushed
the
chore/dependency-updates
branch
from
October 31, 2026 21:24
96a5c36 to
abac3ba
Compare
validateProjectName accepted '/', absolute paths and 'foo/../..' because a name with slashes that did not match the scoped-package pattern skipped the URL-friendly check. Combined with the 'directory exists, delete it?' prompt, one confirmation could recursively delete a folder outside the working directory. Reject such names (and '@scope/..'), and resolve the project path through resolveProjectPath, which refuses anything that is not a new folder strictly inside the current directory.
msmps
force-pushed
the
fix/project-path-safety
branch
from
October 31, 2026 21:31
e7867b7 to
66ce892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateProjectName accepted '/', absolute paths and 'foo/../..' because a
name with slashes that did not match the scoped-package pattern skipped the
URL-friendly check. Combined with the 'directory exists, delete it?' prompt,
one confirmation could recursively delete a folder outside the working
directory.
Reject such names (and '@scope/..'), and resolve the project path through
resolveProjectPath, which refuses anything that is not a new folder strictly
inside the current directory.
Stack
Merge bottom-up into
main: merge #100 first, then each PR above it (GitHub retargets the next one tomain).main