Repository navigation
Conversation
kkin-here
force-pushed
the
v3_streaming_v3_reader
branch
2 times, most recently
from
October 27, 2026 13:09
7ec90dd to
5bb363c
Compare
Merged
kkin-here
force-pushed
the
v3_streaming_cli_poc
branch
from
November 5, 2026 12:03
1310fa6 to
e231c08
Compare
…vice files in the CLI fat jar Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
…smoke test for v3 to null Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
kkin-here
force-pushed
the
v3_streaming_v3_reader
branch
from
November 10, 2026 12:18
5bb363c to
118e07c
Compare
kkin-here
marked this pull request as ready for review
November 10, 2026 12:20
This comment was marked as off-topic.
This comment was marked as off-topic.
gunplar
reviewed
Nov 13, 2026
| @Test | ||
| void serviceLoaderFindsBuiltInProviders() { | ||
| assertEquals(Set.of("null", "random"), providers.all().stream().map(IStorageProvider::getName).collect(Collectors.toSet())); | ||
| assertEquals(Set.of("null", "random", "v3"), providers.all().stream().map(IStorageProvider::getName).collect(Collectors.toSet())); |
Collaborator
There was a problem hiding this comment.
I would say better rename it to "naksha-v3", or any hint that it is Naksha, to differentiate from IML, Datahub, FFW storages, etc...
gunplar
approved these changes
Nov 13, 2026
gunplar
left a comment
gunplar
left a comment
Collaborator
There was a problem hiding this comment.
Approve as not to block development, we accept fixing issues later.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.