Repository navigation
V3 streaming cli poc - #678
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
d297185 to
ffb062f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
| super(session, request, session.getOptions(), request.sequential() ? 1 : 16); | ||
| this.config = config; | ||
| this.states = request.queryHistory() ? config.statesPerFeature() : 1; | ||
| this.start = request.getRaw(CURSOR) instanceof Number n ? n.longValue() : 0L; |
There was a problem hiding this comment.
This duplicates StreamRequest.minVersion() I feel?
There was a problem hiding this comment.
minVersion is a version filter of the request, but random has no versions, its position is state * count + index. Putting that into minVersion would make the recovery request claim a version range that doesn’t exist. minVersion is used for example in v3 reader draft I created, because there position really is a version.
| Object v = e.getValue(); | ||
| copy.put(e.getKey(), v instanceof Id id ? id.text() : v); | ||
| } | ||
| return Platform.toJSON(copy); |
There was a problem hiding this comment.
Why do we need a copy here? Platform.toJSON(request) seems enough.
There was a problem hiding this comment.
I think we need to fix Id class, rather than having this workaround.
There was a problem hiding this comment.
Actually, add an if in Platform.unbox(), if it's Id then unbox to value.text.
EDIT: sorry this might be wrong in the grand scheme of Proxy. But that's my idea of targeting this problem. I would want to avoid cloning objects like this as it impacts performance.
There was a problem hiding this comment.
fair point, fixed: I added a jackson serializer for Id in lib-base that writes the text, so toJson requires no copies now
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
gunplar
left a comment
gunplar
left a comment
There was a problem hiding this comment.
Approved. We can continue refining if needed later.
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
…-C, clearer config and resume errors Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
… ignoreTransactions Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
… commands on the new write and recovery contract Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
…ntil discussed Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
1310fa6 to
e231c08
Compare
Code Coverage
|
No description provided.