Skip to content

feat(yucca sdk): record skipped scheduled backups in metrics history - #287

Merged
insertish merged 1 commit into
mainfrom
feat/skipped-backup-metric
Nov 17, 2026
Merged

insertish merged 1 commit into
mainfrom
feat/skipped-backup-metric

Conversation

@insertish

Copy link
Copy Markdown
Member

No description provided.

@futo-kritika

futo-kritika Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Re-runViewConfidence Score: 5/5

[Medium risk] No findings. Approved.

Summary

Records skipped scheduled backups in metrics history.

  • ScheduleService reports skips for repositories with queued or running backups on metrics-capable backends.
  • MetricsService counts skips without replacing repository last-backup metrics; MetricsHistoryModal displays them as skipped.
  • The migration’s rollback preserves history rows while clearing the unsupported skipped status.

What's good

  • Rollback now preserves history rows instead of deleting them.
  • The preservation test now compares the last-backup timestamp before and after a skip.
Review context · 0/5 commands · 2 overlapping pull requests
  • Risk: The risk rests on a forward Postgres enum migration (ALTER TYPE ADD VALUE) and a new early-return path in submitBackupEnd. Both are covered by integration tests, and a revert undoes them. The down migration nulls skipped history statuses instead of deleting rows, which differs from what the last review described, so that earlier P1 no longer applies.
  • Commands run: none
  • Also open:
    • #284 changes packages/yucca-sdk/orchestration-api/src/services/schedule.service.spec.ts packages/yucca-sdk/orchestration-api/src/services/schedule.service.ts
    • #286 changes packages/yucca-sdk/orchestration-ui/src/lib/locales/en-XA.po packages/yucca-sdk/orchestration-ui/src/lib/locales/en.po

Reviews (2) · Last reviewed commit: "feat(yucca sdk): record skipped schedule..." · openai/gpt-6.1-sol · $0.27

@insertish
insertish force-pushed the feat/skipped-backup-metric branch from a0a0f86 to 5278e24 Compare November 17, 2026 18:18

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 5/5 with medium risk at 5278e24.

@insertish
insertish merged commit 0360677 into main Nov 17, 2026
17 checks passed
@insertish
insertish deleted the feat/skipped-backup-metric branch November 17, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant