Skip to content

feat(yucca sdk): show next backup time in setup modal - #286

Merged
insertish merged 4 commits into
mainfrom
feat/202-next-backup-time
Nov 17, 2026
Merged

insertish merged 4 commits into
mainfrom
feat/202-next-backup-time

Conversation

@insertish

Copy link
Copy Markdown
Member

closes #202

@futo-kritika

futo-kritika Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Re-runViewConfidence Score: 5/5

[Low risk] No findings. Approved.

Summary

Shows the next scheduled backup time during Immich setup.

  • OnboardingStep4FirstBackup shows today’s or tomorrow’s scheduled run time, with the server timezone when different.
  • ScheduleEditor and the setup dialog display zero-padded, 24-hour times.

What's good

  • Adds deterministic coverage for today, tomorrow, and differing server timezones.
  • Shares time formatting between schedule editing and onboarding.
Review context · 0/5 commands · 2 overlapping pull requests
  • Risk: The risk rests on a display-only change to the onboarding first-backup dialog. It adds locale strings and tests, touches no data, auth or configuration, and moves no dependency version.
  • Commands run: none
  • Also open:
    • #288 changes packages/yucca-sdk/orchestration-ui/src/lib/components/schedules/ScheduleEditor.svelte packages/yucca-sdk/orchestration-ui/src/lib/locales/en-XA.po packages/yucca-sdk/orchestration-ui/src/lib/locales/en.po
    • #287 changes packages/yucca-sdk/orchestration-ui/src/lib/locales/en-XA.po packages/yucca-sdk/orchestration-ui/src/lib/locales/en.po

Reviews (7) · Last reviewed commit: "fix(yucca sdk): format the next backup t..." · openai/gpt-6.1-sol · $0.54

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 5/5 with low risk at caaa5a0.

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 5/5 with low risk at c899eb6.

@insertish
insertish force-pushed the feat/202-next-backup-time branch from c899eb6 to af62a31 Compare November 17, 2026 17:59
Base automatically changed from feat/schedule-time-zone to main November 17, 2026 18:29

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 5/5 with low risk at 9191ec0.

@futo-kritika futo-kritika Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kritika: confidence 5/5 with low risk at ce26d54.

@insertish
insertish merged commit bd19fdf into main Nov 17, 2026
17 checks passed
@insertish
insertish deleted the feat/202-next-backup-time branch November 17, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing the first-backup dialog cancels the whole setup; add "start at the scheduled time"

1 participant