Repository navigation
bump: move a release pin's strip_prefix with the release - #376
Merged
Merged
Conversation
Only URL pins move a versioned strip_prefix along with the release, but release pins need that too. Move it into a helper that both can call. Signed-off-by: Martin Pitt <martin@amutable.com>
Only URL pins moved a versioned strip_prefix, so bumping gh from v2.103.0 to v2.103.3 kept the old archive directory and broke the build of tools:gh. Move it for release pins too. Signed-off-by: Martin Pitt <martin@amutable.com>
daandemeyer
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only URL pins moved a versioned strip_prefix, so bumping gh from v2.103.0 to
v2.103.3 kept the old archive directory and broke the build of tools:gh. Move
it for release pins too.
Signed-off-by: Martin Pitt martin@amutable.com
Spotted in #375 (which I fixed manually). Running bump with this branch now gives an identical result.