Skip to content

Improve bootstrap support controls and session restore - #1798

Merged
dacowan404 merged 1 commit into
CDCgov:devfrom
glstott:1795-bootstrap_disappears
Oct 23, 2026
Merged

dacowan404 merged 1 commit into
CDCgov:devfrom
glstott:1795-bootstrap_disappears

Conversation

@glstott

@glstott glstott commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Issue

Summary

  • Detect valid bootstrap support values on non-root internal tree nodes.
  • Recognize fractional, percentage, and percent-marked support values while ignoring:
    • Numeric leaf labels.
    • Root-only numeric labels.
    • Named internal nodes.
    • Out-of-range values.
  • Disable the Bootstrap calculation tab when an imported tree already contains bootstrap support.
  • Direct users with imported support values to the display controls under the Branches tab.
  • Keep Bootstrap calculation guidance available for trees without imported support.
  • Add an expanded-by-default Bootstrap Support section under Branches with controls for:
    • Showing or hiding bootstrap values.
    • Decimal precision.
    • Minimum visible support.
    • Bootstrap label size.
  • Manage numeric bootstrap labels independently from named internal-node labels.
  • Preserve bootstrap visibility, size, precision, and threshold settings across:
    • Tree layout redraws.
    • Closing and reopening the Phylogenetic Tree view.
    • Bootstrap recalculation.
    • Session save and restore.
  • Provide backward-compatible defaults for sessions created before the new display settings existed.
  • Repair dashboard restoration so saved layouts do not briefly create and then replace a temporary default view.
  • Preserve the restored tree instance, open settings dialog, active pane, and docked key-table state while session restoration completes.
  • Add mixed-label Newick data, trees with and without bootstrap support, aligned sequences, and a dedicated Cypress dataset profile.
  • Expand the bootstrap journey coverage to include imported support, independent named labels, formatting, filtering, visibility, recalculation, and current/legacy session round-trips.

- detect imported bootstrap values and disable redundant calculation controls
- add independent visibility, size, precision, and threshold settings under Branches
- preserve support display preferences across redraws, recalculation, and session restores
- restore saved dashboards without creating a temporary default view or stealing focus
- add fixtures and expanded unit and Cypress coverage for imported and calculated support

Refs CDCgov#1795
@dacowan404
dacowan404 merged commit 34bb5fc into CDCgov:dev Oct 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants