Repository navigation
docs: Add the ClickHouse Cloud guide - #59
Merged
Merged
Conversation
Neon, PlanetScale and Atlas each have an integration guide; ClickHouse Cloud, the fourth hosted destination the packages were verified against, had none, and what the November run turned up lived only in a demo repository's notes. The idling behavior, the 8443-only port and the replica race in the hand-applied --print-sql script are the things a first run on Cloud trips over, so they belong where the package's users look.
 [Low impact] The PR appears safe to merge; the previous finding is fixed and no new issues were found. SummaryAdds a ClickHouse Cloud setup guide and links it from the main README.
Reviews (4) · Last reviewed commit: "docs: Qualify the counterpart claim in t..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…mples The mirror tables are ReplacingMergeTree, so a merge collapses each row to its newest version; the guide and the package README both claimed every version was kept. The guide also pointed at the Postgres query guide and the Postgres embed snippet without saying what differs.
…embed The guide never said it was Postgres-only, so a reader arriving from a search took the engine for a Postgres tool, and the Atlas guide sent its "library" link to a snippet that imports PostgresDestination. The README already carries the one-sentence scoping; the guide now does too, with the three package READMEs it defers to.
The guide describes init --print-sql, which the MongoDB command does not have, so "every option has a counterpart" promised a workflow that package's users cannot use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/integrations/clickhouse-cloud.md, the fourth hosted-destination guide alongside Neon, PlanetScale and MongoDB Atlas, and links it from the README's integration list.defaultpassword and its reset, the IP access list, the HTTPS endpoint and what to prepend to it, and that no CA is needed.listenkeeps it billing, and a cold first command waits for the wake), and only port 8443 is exposed, which a 443-only network cannot reach.--print-sqlscript racing DDL replication, and "run it again" as the fix since every statement is idempotent.default.getting-started.mdnow says it shows Postgres and names the three package READMEs that hold the counterparts, and the Atlas guide's "library" link goes to the MongoDB README'sMongoDestinationsnippet instead of the Postgres one.