Repository navigation
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Problem
The
TransitionandTransitionGroupbuilt-in components expose apersistedprop that is not included in the documentation, but in the shipped typescript types.Therefore various code editors or IDEs suggest this prop but neither the shipped types nor the documentation explain what it does.
Proposed Solution
This PR adds documentation for the
persistedprop of theTransitionandTransitionGroupbuilt-in components.The text is taken from the corresponding comment in code (line breaks were adjusted to be readable and not overflow in rendered documentation):
https://github.com/vuejs/core/blob/0ff253bfba3ee8d3d65448bd44ad890fd01b0ecd/packages/runtime-core/src/components/BaseTransition.ts#L37-L42
Additional Information
I am not sure whether this prop is actually intended to be part of the public API.
If not, this PR can just be closed again.
However it may be a problem then that the typescript types for the props make editors suggest parts of an internal API then?