Repository navigation
TimingSrcConnector: force pause after fallback attempt at muted autoplay fails - #1150
aspaseltiner-vimeo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 72.59% 72.35% -0.24%
==========================================
Files 7 7
Lines 613 615 +2
==========================================
Hits 445 445
- Misses 168 170 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d79fc54. Configure here.
d79fc54 to
b2576fc
Compare
|
|
2df160f to
b2576fc
Compare

After an autoplay failure due to a
NotAllowederror, the player currently tries muting the video and playing again. In some circumstances (for example, on iOS with low-power mode enabled), autoplay will still be blocked, causing the player to get stuck in a weird state -- for an example of the playback getting stalled, can test using https://codepen.io/Alex-Paseltiner/pen/yyVjVBP on an iOS device with low-power mode enabled:Fix by pausing the video after catching a second
NotAllowederror.