Skip to content

TimingSrcConnector: force pause after fallback attempt at muted autoplay fails - #1150

Closed
aspaseltiner-vimeo wants to merge 1 commit into
masterfrom
fix/pause-after-autoplay
Closed

aspaseltiner-vimeo wants to merge 1 commit into
masterfrom
fix/pause-after-autoplay

Conversation

@aspaseltiner-vimeo

@aspaseltiner-vimeo aspaseltiner-vimeo commented Jun 3, 2026 •

Copy link
Copy Markdown

After an autoplay failure due to a NotAllowed error, the player currently tries muting the video and playing again. In some circumstances (for example, on iOS with low-power mode enabled), autoplay will still be blocked, causing the player to get stuck in a weird state -- for an example of the playback getting stalled, can test using https://codepen.io/Alex-Paseltiner/pen/yyVjVBP on an iOS device with low-power mode enabled:

IMG_6266

Fix by pausing the video after catching a second NotAllowed error.

@codecov

codecov Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.35%. Comparing base (ce600ad) to head (b2576fc).

Files with missing lines Patch % Lines
src/lib/timing-src-connector.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   72.59%   72.35%   -0.24%     
==========================================
  Files           7        7              
  Lines         613      615       +2     
==========================================
  Hits          445      445              
- Misses        168      170       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit d79fc54. Configure here.

Comment thread dist/player.es.js Resolved
@aspaseltiner-vimeo
aspaseltiner-vimeo force-pushed the fix/pause-after-autoplay branch from d79fc54 to b2576fc Compare June 3, 2026 12:47
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants