Repository navigation
Conversation
AlbanSdl
reviewed
Oct 25, 2026
| @@ -0,0 +1,29 @@ | |||
| // src/apps/webhooks.module.ts | |||
Member
There was a problem hiding this comment.
Suggested change
| // src/apps/webhooks.module.ts |
| /** | ||
| * Defines the `Dnum` module. | ||
| */ | ||
| @Module({}) |
Member
There was a problem hiding this comment.
Je mettrais plus le service ici du coup en exports, ça me semble plus logique
Member
There was a problem hiding this comment.
le fichier interface c'est surtout pour les types qui sortent de la db, ces types là tu pourrais les mettre n'importe où
| */ | ||
| @Module({ | ||
| controllers: [WebhooksController], | ||
| providers: [WebhooksService, DnumService], |
Member
There was a problem hiding this comment.
Du coup j'utiliserais plutôt un import ici du coup
Comment on lines
+46
to
+49
| const existingUes = await this.prisma.ueof.findMany({ | ||
| where: { code: { in: ues.map((ue) => ue.ue) } }, | ||
| select: { code: true }, | ||
| }); |
Member
There was a problem hiding this comment.
Au lieu de faire un findMany, pk pas vérifier si createdAt === updatedAt dans la valeur retournée ? (et tant pis si c'est jamais c'était inaccurate, c'est juste une stat retournée à un webhook qui ne le lira jamais 🤷)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.