Skip to content

fix(stovepipe): Retain request build associations - #1011

Merged
prathshenoy merged 1 commit into
mainfrom
prath/request-build-association
Nov 6, 2026
Merged

prathshenoy merged 1 commit into
mainfrom
prath/request-build-association

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What:

  • Save each request’s build association before handing the build to status polling and analysis.
  • Reuse the associated build when dispatch is retried.

Why:

  • Let work registered before build dispatch find the build while it is running. Previously, the request only identified its build after completion, so ordered issue tracking could not follow a running validation.
  • Avoid starting another build when retrying a handoff after the association was saved. A crash before saving it can still create a duplicate, so this does not guarantee exactly one CI build.

Test Plan

  • Add unit tests.

Revert Plan

  • Revert the dependent tracking change first, then revert this PR. Keep the additive database column; older code can ignore it. Provision the column before deploying this change.

Issue Links

Stack

  1. fix(stovepipe): Retain request build associations #1011
  2. fix(stovepipe): Track validations in order #1010

@prathshenoy
prathshenoy added this pull request to stack #1016 November 5, 2026 16:26
@prathshenoy
prathshenoy removed this pull request from stack #1016 November 5, 2026 19:02
@prathshenoy
prathshenoy added this pull request to stack #1019 November 5, 2026 19:02
@prathshenoy
prathshenoy removed this pull request from stack #1019 November 5, 2026 19:39
@prathshenoy
prathshenoy added this pull request to stack #1020 November 5, 2026 19:40
@prathshenoy
prathshenoy marked this pull request as ready for review November 5, 2026 20:03
@prathshenoy
prathshenoy force-pushed the prath/request-build-association branch from dd52234 to 47b421f Compare November 6, 2026 17:35
@prathshenoy
prathshenoy force-pushed the prath/request-build-association branch from 47b421f to d13fc93 Compare November 6, 2026 17:36
@prathshenoy
prathshenoy added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit cf86b5c Nov 6, 2026
22 checks passed
@prathshenoy
prathshenoy deleted the prath/request-build-association branch November 6, 2026 18:10
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Nov 6, 2026
## Summary
**What**:
- Apply issue updates in request order while builds and analysis
continue concurrently.

**Why**:
- Prevent newer refreshes from discarding an earlier validation’s
delayed final results. This can leave old failures open and prevent
newly detected failures from being tracked.
- Preserve distinct issue occurrences in history and repair selection. A
clean validation must close an earlier opening before the next
validation can reopen the same failure and trigger a new repair.

## Test Plan
- [x] Add unit tests.
- [x] Verify queue-head blocking and storage updates against MySQL.
- [x] Verify issue-tracking completion and DLQ recovery end-to-end.

## Revert Plan
- Pause admission and finish or safely abandon the new tracking jobs
before reverting. Keep the additive database column; older code can
ignore it.

## Issue Links
-
[CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis-issue-track)

## Stack
1. uber#1011
1. uber#1010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants