Repository navigation
fix(athena): route by each engine's rules when the combined tokenizer fails [CLAUDE] - #8629
Open
masiljangajji wants to merge 1 commit into
Open
masiljangajji wants to merge 1 commit into
masiljangajji wants to merge 1 commit into
Conversation
… fails [CLAUDE] Routing tokenizes with the union of Hive and Trino rules, which rejects literals that are valid in a single engine: '\' or ESCAPE '\' in Trino and "a\"b" in Hive. A failure there only means the union can't route the statement, so each engine's own tokenizer is tried and used if its tokens route to that engine. Statements the union tokenizes are unaffected. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8628
The routing step tokenizes with the combined Hive and Trino rules and raises when that fails, so literals valid in only one engine, like
'\'in Trino or"a\"b"in Hive, never get routed. Now, when it fails, each engine's tokenizer is tried and used only if its tokens route to that engine. Statements the combined tokenizer handles take the same path as before.Written with help from Claude.