Repository navigation
[SCAL-347790] Support CreateConversation for SpotterX - #230
Merged
Merged
Conversation
Rifdhan
commented
Nov 6, 2026
Rifdhan
commented
Collaborator
- Detect Spotter version and use the appropriate handling for CreateAnalysisSession tool call
- Plumb through existing client code to make SpotterX API call
- Parse and send dashboard_id if present for SpotterX
- Update thoughtspot-client to take and provide additional props required for SpotterX (tenantId, orgId, userId)
- Rename a few utils in event stream processing logic to prepare for SpotterX variant in the next change
- Add and update test coverage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ThoughtSpot client and service layers to support SpotterX routing and liveboard context scoping. Key changes include replacing the getThoughtSpotClient helper with direct ThoughtSpotClient instantiation, updating ClientContext to require tenantId, orgId, and userId, renaming Spotter 3 methods and event stream processors, and implementing createSpotterXConversation with routing logic in callCreateAnalysisSession. I have no feedback to provide as there are no review comments.
- Detect Spotter version and use the appropriate handling for CreateAnalysisSession tool call - Plumb through existing client code to make SpotterX API call - Parse and send dashboard_id if present for SpotterX - Update thoughtspot-client to take and provide additional props required for SpotterX (tenantId, orgId, userId) - Rename a few utils in event stream processing logic to prepare for SpotterX variant in the next change - Add and update test coverage
Rifdhan
force-pushed
the
SCAL-347790-support-spotterx-create-conversation
branch
from
November 6, 2026 18:47
d9111e6 to
10e13ed
Compare
mouryabalabhadra
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.