Repository navigation
[SCAL-347792] Add SpotterX flag check util - #228
Merged
Merged
Conversation
Rifdhan
commented
Nov 3, 2026
Rifdhan
commented
Collaborator
- Util to check if SpotterX is enabled in the cluster
- Refactor sessionInfo fetch stack to return the actual response structure seen in the API response, instead of reshaping it to a new arbitrary structure
- This makes it easier to reason about the state of flags, and resolves some any-cast type issues
- Add test coverage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the SessionInfo handling by passing the raw upstream response directly instead of mapping it to a flattened structure. Properties such as cluster details, Mixpanel configurations, and feature flags are now nested under configInfo, and all dependent components (MixpanelTracker, BaseMCPServer, and associated tests) have been updated accordingly. Additionally, a new isSpotterXEnabled check has been introduced. No review comments were provided, and I have no further feedback as the changes are clean and well-tested.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://scal-347792-add-spotterx-flag-util-thoughtspot-mcp-server.thoughtspot-485.workers.dev (commit f818944)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
- Util to check if SpotterX is enabled in the cluster - Refactor sessionInfo fetch stack to return the actual response structure seen in the API response, instead of reshaping it to a new arbitrary structure - This makes it easier to reason about the state of flags, and resolves some any-cast type issues - Add test coverage
Rifdhan
force-pushed
the
SCAL-347792-add-spotterx-flag-util
branch
from
November 3, 2026 18:18
4d270aa to
f818944
Compare
mouryab
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.