Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Query-string access logging can leak bearer tokens, and JWT validation accepts tokens without expiration, leaving critical credential-exposure and token-lifetime enforcement gaps.
6 open issues
Redact credentials from access-log query strings · New Require token expiration and test missing exp · New Parse IPv6 JWKS authorities correctly · New Reload JWKS CA changes without restarting pods · New Assert envoy has no ServiceAccount token mount · New Describe the shared signing key’s broader impact · New
What changed in this PR
Adds the monorepo’s first component: a Helm-packaged management proxy that lets the distributed control plane configure gateway resources through authenticated Kubernetes API access.
Changes:
- Combines Envoy token validation with
kubectl proxy, scoped permissions, TLS, optional mutual TLS, and network controls. - Adds chart tests, Docker-based sidecar tests, schema validation, CI, and dependency updates.
- Documents configuration, MVP results, and remaining integration checks. ADR 0005 and ADR 0011 remain proposed.
| File | Description |
|---|---|
REUSE.toml |
Licenses the Go checksum file. |
README.md |
Adds the component to the repository layout. |
management-proxy/test/validate-schemas.sh |
Validates rendered resources against Kubernetes and CRD schemas. |
management-proxy/test/sidecar_test.go |
Tests authentication, TLS, forwarding, and health endpoints. |
management-proxy/test/kubectl_proxy_test.go |
Checks the forwarding path allowlist. |
management-proxy/test/helpers_test.go |
Provides rendering, certificate, and token helpers. |
management-proxy/test/go.sum |
Records test dependency checksums. |
management-proxy/test/go.mod |
Defines the Go test module and dependencies. |
management-proxy/test/envoy_test.go |
Validates each profile’s Envoy configuration. |
management-proxy/test/echo.Dockerfile |
Pins the forwarding-test echo image. |
management-proxy/README.md |
Introduces installation, layout, and checks. |
management-proxy/Makefile |
Adds component lint and test targets. |
management-proxy/chart/values.yaml |
Defines and documents chart configuration. |
management-proxy/chart/tests/route_test.yaml |
Tests routing, authorization expressions, and backend TLS. |
management-proxy/chart/tests/refused-values_test.yaml |
Tests rejection of unsafe or incomplete settings. |
management-proxy/chart/tests/rbac_test.yaml |
Tests namespace-scoped permission bindings. |
management-proxy/chart/tests/networkpolicy_test.yaml |
Tests ingress and egress policy rendering. |
management-proxy/chart/tests/envoy-config_test.yaml |
Tests conditional Envoy configuration. |
management-proxy/chart/tests/deployment_test.yaml |
Tests token isolation, mounts, and proxy arguments. |
management-proxy/chart/tests/certificates_test.yaml |
Tests certificate identities and issuance settings. |
management-proxy/chart/templates/service.yaml |
Exposes the sidecar’s TLS listener. |
management-proxy/chart/templates/route.yaml |
Adds the management route and kgateway policies. |
management-proxy/chart/templates/rbac.yaml |
Creates the ServiceAccount and namespace-scoped roles. |
management-proxy/chart/templates/pdb.yaml |
Adds a disruption budget. |
management-proxy/chart/templates/networkpolicy.yaml |
Restricts pod ingress and egress. |
management-proxy/chart/templates/deployment.yaml |
Deploys the hardened Envoy and kubectl containers. |
management-proxy/chart/templates/configmap-envoy.yaml |
Configures authentication, forwarding, TLS, and health listeners. |
management-proxy/chart/templates/certificates.yaml |
Requests server and optional client certificates. |
management-proxy/chart/templates/_helpers.tpl |
Supplies shared rendering and value-validation helpers. |
management-proxy/chart/ci/sidecar-values.yaml |
Configures isolated sidecar tests. |
management-proxy/chart/ci/existing-secrets-values.yaml |
Exercises existing certificates and multiple issuers. |
management-proxy/chart/ci/cert-manager-values.yaml |
Exercises the standard cert-manager setup. |
management-proxy/chart/ci/cert-manager-mtls-values.yaml |
Exercises mutual TLS and a custom JWKS CA. |
management-proxy/chart/Chart.yaml |
Defines chart metadata and Kubernetes compatibility. |
management-proxy/chart/.helmignore |
Excludes test profiles and suites from packaging. |
management-proxy/.kube-linter.yaml |
Configures the topology-spread lint exception. |
Makefile |
Integrates component linting and Docker-based checks. |
docs/developer/management-proxy.md |
Documents implementation, configuration, testing, and MVP results. |
docs/decisions/0011-test-components-with-helm-unittest-and-testcontainers.md |
Proposes component testing frameworks. |
docs/decisions/0005-reuse-an-existing-kubernetes-api-proxy.md |
Updates the proposed TLS and signing-key approach. |
CONTRIBUTING.md |
Lists component tooling and check requirements. |
AGENTS.md |
Updates check commands and documentation guidance. |
.github/workflows/management-proxy.yml |
Runs component linting and container tests in CI. |
.github/dependabot.yml |
Adds chart-image and Go dependency updates. |
Review effort: Max
nb-99
force-pushed
the
feature/management-proxy-mvp
branch
from
November 19, 2026 09:51
def55d1 to
88b5cdd
Compare
Add the Helm chart of the management proxy: an Envoy sidecar that validates the Gateway Token in front of kubectl proxy, with RBAC, NetworkPolicy, cert-manager certificates and the management route. Test the chart with helm-unittest and the sidecar with Go Testcontainers, as proposed in ADR 0011. Run the lint and the tests in a new CI workflow, and add make check-all for the Docker-based tests. Update ADR 0005 and the developer guide with the MVP results. Configure Dependabot for the images and the Go test module.
nb-99
force-pushed
the
feature/management-proxy-mvp
branch
from
November 19, 2026 11:15
88b5cdd to
a2c314d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds the MVP of the management proxy, the first component of this monorepo. The distributed control plane (dCP) uses it
to configure the gateway resources of a data-plane cluster through the Kubernetes API, as proposed in
ADR 0004 and
ADR 0005.
The component is a Helm chart without our own image:
the request, removes the
Authorizationand impersonation headers, and allows only the configured clients.kubectl proxyforwards each accepted request with a ServiceAccount that has write access only in the configurednamespaces.
--accept-pathsblocks Secrets and ConfigMaps.certificates. kgateway connects to the sidecar over TLS. Mutual TLS is an option that is off by default.
Changes
management-proxy/chart/ci/, helm-unittest suites, Go tests with testcontainers-go and a schema validation scriptproposed: test components with helm-unittest and Go Testcontainers instead of bash scriptsproposed: TLS instead of mTLS for the MVP, one signing key for all routes, links to the MVP resultsmanagement-proxy.yml,make checknow runs the component lints, newmake check-allalso runs the Docker-based tests, Dependabot for the images and the Go test moduleHow to review
chart/templates/configmap-envoy.yaml, the RBAC inchart/templates/rbac.yamland the values that the chart refusesin
chart/templates/_helpers.tpl.chart/tests/andtest/show the expected behaviour.ADR 0005 and ADR 0011 stay
proposed. Merging this PR does not accept them.Verification
make check: REUSE, Markdown lint,helm lintwith all value profiles, kube-linter, kubeconform against Kubernetes1.30, 1.36 and 1.37 with the Gateway API, kgateway and cert-manager CRDs, 40 helm-unittest tests and ShellCheck. All
pass.
make -C management-proxy test: gofmt,go vetand the Go Testcontainers tests of the Envoy configuration, thekubectl proxypaths and the sidecar. All pass.Results of the MVP, also for what is not tested yet:
kgateway itself, mutual TLS in a cluster, enforced NetworkPolicies and the rotation of certificates and JWKS keys.
Notes
make check. So the Helm and kube-linter requirements thatmake checknow has only affectlocal runs, and the new
management-proxy.ymlworkflow installs them for CI.CONTRIBUTING.mdlists the new localrequirements.
tag and the digest together.
of
kubectl proxy. We also use it for load and smoke tests.