Repository navigation
Conversation
This was referenced Oct 30, 2026
aRustyDev
force-pushed
the
stack/1/decouple-playback-core
branch
from
October 30, 2026 03:33
2c39a6b to
4018f1f
Compare
aRustyDev
force-pushed
the
stack/1/decouple-playback-core
branch
from
October 30, 2026 03:47
4018f1f to
45fc627
Compare
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Separate playback from terminal setup and rendering so additional frontends can share one playback session.
Important
#blocked-by #139 (which is blocked by #138)
Please wait for #138 and #139 to merge before reviewing this PR. The Files changed tab includes their configuration and testing work because this PR targets
main. After they merge, I’ll rebase this branch so the diff contains only the playback-core refactor.#blocking #142
Incremental core diff for reference.
Changes
Application.flowchart LR T[Terminal input] --> A[Application commands] N[MPRIS / SMTC commands] --> A A --> P[Player] P --> U[Playback state and updates] U --> V[Terminal and native adapters]Why this approach
The player currently creates and owns the terminal UI and platform controls. Adding another frontend there would tie playback to more UI setup and lifecycle rules.
Moving composition into
Applicationkeeps one player and one command path. Read-only state lets adapters observe playback without giving them direct control of the audio sink. A separate player per frontend would risk conflicting sessions; a generic frontend/plugin framework would add abstraction before it is needed. This change keeps the existing concrete adapters and feature gates.Validation
55 default Cargo tests passed on macOS. Formatting, default/no-default Nextest, curated feature checks, and mutation inventories passed. Native Linux MPRIS suites passed with and without defaults. Private-item documentation passes with broken rustdoc links denied. Tests render audio in memory; live audio/D-Bus integration and native Windows tests were not run locally.