Repository navigation
Conversation
aRustyDev
marked this pull request as ready for review
October 30, 2026 02:34
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Run Lowfi's existing features on Linux, Windows, and macOS in CI so platform-specific failures surface before merge.
Changes
Expand the existing test workflow with native runners:
mprismedia-controls(SMTC)All three also cover
scrapeandextra-audio-formats. The workflow checks formatting, runs default and no-default tests, tests native features, and checks native features without defaults. Build/test commands use--locked.Correct the window assertions for the extra row added by Lowfi's Windows renderer and include the formatting fixes required by the checks. The terminal rendering stays the same.
Why this approach
The existing workflow runs only on Linux with default features. That leaves Windows media controls and optional feature combinations outside its coverage.
Native runners exercise platform code and assertions that cross-compilation cannot run. A curated feature list avoids enabling Linux and Windows integrations together. This workflow uses standard Cargo commands; the extra test tooling is proposed separately in #139.
Validation
cargo fmt --checkpassed andcargo test --lockedpassed all 33 tests on macOS. Native Windows tests were not run locally.