Skip to content

ci(platforms): test native features on Linux, Windows, and macOS - #137

Closed
aRustyDev wants to merge 2 commits into
talwat:mainfrom
aRustyDev:stack/0/ci
Closed

aRustyDev wants to merge 2 commits into
talwat:mainfrom
aRustyDev:stack/0/ci

Conversation

@aRustyDev

@aRustyDev aRustyDev commented Oct 30, 2026 •

Copy link
Copy Markdown

TL;DR

Run Lowfi's existing features on Linux, Windows, and macOS in CI so platform-specific failures surface before merge.

Changes

Expand the existing test workflow with native runners:

Runner Platform feature tested
Linux mpris
Windows media-controls (SMTC)
macOS Common features

All three also cover scrape and extra-audio-formats. The workflow checks formatting, runs default and no-default tests, tests native features, and checks native features without defaults. Build/test commands use --locked.

Correct the window assertions for the extra row added by Lowfi's Windows renderer and include the formatting fixes required by the checks. The terminal rendering stays the same.

Why this approach

The existing workflow runs only on Linux with default features. That leaves Windows media controls and optional feature combinations outside its coverage.

Native runners exercise platform code and assertions that cross-compilation cannot run. A curated feature list avoids enabling Linux and Windows integrations together. This workflow uses standard Cargo commands; the extra test tooling is proposed separately in #139.

Validation

cargo fmt --check passed and cargo test --locked passed all 33 tests on macOS. Native Windows tests were not run locally.

@aRustyDev aRustyDev changed the title Expand native CI coverage Test native features on Linux, Windows, and macOS Oct 30, 2026
@aRustyDev aRustyDev changed the title Test native features on Linux, Windows, and macOS ci(platforms): test native features on Linux, Windows, and macOS Oct 30, 2026
@aRustyDev
aRustyDev marked this pull request as ready for review October 30, 2026 02:34
@danielwerg

Copy link
Copy Markdown
Collaborator

@danielwerg danielwerg closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants