Repository navigation
Narrow Vale to Fly's word list and doubled words - #2595
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
Author
|
Matched the prediction: https://github.com/superfly/docs/actions/runs/39829330722
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrows the Vale check to the two things worth having: Fly's house word list and doubled words.
What changes
Packagespins and about 55 lines of rules that were already switched off.Fly.WordListandVale.Repetition.Vale.Repetitionis set to warning, since by default a doubled word shows as a red annotation.Vale.Avoidis off: its one reject-list entry,healthcheck, is already in the word list, so it would flag the same word twice.free tier: all 4 hits are pages correctly saying there is no free tier, and the suggested "free allowances" doesn't exist for new orgs either.k8s: all 4 hits are literal commands likefly ext k8s create, or the k8s.io URL.data are: the one hit, "healthcare apps and data are", is correct.flyctl/cmd/andapi/machines/models.mdxare excluded. They're generated in other repos, and now that the file list works, every flyctl release PR would otherwise get suggestions nobody can act on here.vale sync, since there's nothing left to download.Spelling stays off for good, so https://github.com/superfly/docs-tracking/issues/359 can close as not planned.
On main this takes the findings from 112 to 66. Nothing about how the check behaves changes: it looks only at the files a PR changes, never blocks a merge, and isn't a required check.
How this PR tests itself. The second commit fixes a real "a a" typo and one
in order toin two blueprints. That leaves exactly three findings inblueprints/shared-nothing.mdx, so CI should show 3 annotations, at lines 282, 302 and 440, and nothing else. A green check alone can't tell "found nothing" from "ran nothing".