Repository navigation
fix(core/caniuse): warn when the header list is missing - #5514
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5370
When caniuse is configured but
.head dlis absent, report a warning and return before fetching support data or registering the save callback. The regression covers missing headers and missing definition lists with bothremoveOnSavesettings, plus disabled caniuse and a valid header. This follows up on the regression coverage requested in the closed, unmerged #5374.Lint, all three profile builds, 94 unit tests, 2 builder tests and 4 headless tests passed on Windows with Chrome. All 1,162 integration tests passed with a local 15-second Jasmine async timeout. Two runs with the default 5-second timeout failed on asynchronous document loads; those logs are preserved in the validation evidence. No timeout changes are included in this PR.
Written with AI: OpenAI Codex generated and reviewed the code and tests and ran the validation.
Proof:
pnpm exec karma start tests/unit/karma.conf.cjs --single-run --browsers ChromeHeadless --grep "Core - Can I Use header"failed on base2aac986a3ceb9708ea80c5307fca57a4c91ddd99with the new test file: four missing-header cases produced no warning, while both controls passed. The same command passed all six tests on161e3ccd162f34b16663ed57ba2512f243f3aee3. Before log · After log.The same document silently omits the table before the fix and shows a warning afterwards. Its caniuse request count falls from one to zero.