Repository navigation
fix(desktop): route organization members to their organization and settings - #9717
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryRoutes organization members without workspace access to their organization instead of the blocked workspace picker.
|
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
GET /api/workspacesnow returnsforwardOrganizationIdwhen a viewer has no workspace, can't create one, and belongs to an organization whose surface can serve them./workspaceforwards them there instead of showing "No workspace access yet", and?redirect=settingslands on the organization's general settings. Ships with the web release, so installed desktop apps and their saved/workspaceroute recover without an update/workspace, so the two can't loop/homeinstead of/workspace/o/<id>/settings/generalfrom the organization view. Without a workspace or organization in the last route it uses/workspace?redirect=settings. It used to fall back to/home, which has no settings, so the menu item appeared to do nothingNot changed: Desktop, Browser, and Terminal settings are still workspace-bound, so members without a workspace can't reach them.
Type of Change
Testing
workspaces/route.test.ts,workspace/page.test.tsx,resolve-app-entry.test.ts,app-routes.test.ts,handoff.test.ts. Reverted each guard (client forward, card suppression, settings destination, route field, lookup failure, rollout, org route, fallback, handoff landing) and watched its test go redbun run type-check, biome on changed files,check:tool-registry-boundary,check:api-validation:strict,check:api-contract-routes,check:test-patterns,check:source-conventions,check:client-boundary,check:boundaries,check:application-graph,check:comment-hygiene,check:utils,check:file-namescheck:auditsand the full test suite left to CIChecklist
test-auditauthoring gate)