Skip to content

fix(app): keep square logos out of loading screens - #8897

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-refresh-wordmark-selection
Oct 10, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-refresh-wordmark-selection

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Use only the configured wordmark on application loading screens. A square brand logo no longer replaces it.
  • Fall back to the canonical Sim SVG when the brand name remains Sim, or the custom brand name otherwise. Preserve explicit custom wordmarks, shared color tokens, and loading behavior.
  • Document the distinction between loading wordmarks and square logos.

Type of Change

  • Bug fix

Testing

Reproduced the square-logo fallback through the running app with a disposable PostgreSQL fixture before the fix. Seven HTTP streaming cases cover default branding, square logos, custom names, explicit wordmarks, and color-only branding. Browser checks cover light/dark at 360, 768, 1440, and 2560 px widths, loading-to-ready, and Files navigation; JSON reports and screenshots saved locally. Signed-out and access-denied checks pass.

All eight applicable cleanup passes, 6 adjacent tests, full root tests (including 36,998 app tests), lint, all 26 workspace type checks, 59 repository audits, generators, block registry, docs manifest, and actionlint passed. No test source changes. An unchanged route-inventory test hit a timeout in the first full run; its isolated run and the complete retry passed unchanged.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 10, 2026 8:08pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’ve reached your flex budget. Increase your flex budget or wait for usage to reset.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the loading fallback matches the stated branding behavior.

Summary

Loading screens now use only the configured wordmark, not the square logo.

  • Loading screens show wordmarks instead of square brand logos.

waleedlatif1 explicitly requested the built-in Sim wordmark for square-logo-only or color-only branding when the brand name remains Sim.

Reviews (1) · Last reviewed commit: "fix(app): keep square logos out of loadi..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 515b50d into staging Oct 10, 2026
48 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-refresh-wordmark-selection branch October 10, 2026 20:20

This branch was successfully deployed

1 active deployment
Preview — 548de2c7 Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant