Repository navigation
fix: resolve scatter embedding keys consistently - #4494
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4494 +/- ##
==========================================
+ Coverage 85.13% 85.37% +0.23%
==========================================
Files 138 138
Lines 12247 12244 -3
==========================================
+ Hits 10427 10453 +26
+ Misses 1820 1791 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
I updated the PR metadata to match Scanpy's checks: a semantic fix title, the numbered release-note fragment (4494.fix.md), and the LLM usage disclosure. The human-review declaration remains unchecked for manual confirmation. The stable, few-extras and lowest-version tests, build, docs and pre-commit had passed on the previous head. Could a maintainer assign the appropriate milestone or apply the 'no milestone' label when convenient? That is currently blocking the title/milestone check. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3803.
Use the existing exact-key-first resolver in legacy
sc.pl.scatter, then fall back toX_when the requested embedding key is absent. This supports custom and explicitly prefixed keys and prevents silently selecting the prefixed coordinates when both keys exist.Keep lookup separate from display names.
diffmapandX_diffmapretain the trivial-component offset and component labels, while the original argument remains available for save naming. No changes to embeddings, expression data, colorbar placement or the shared resolver. The signature/docstring and a release-note fragment describe the supported key lookup.Validation
embedding, labels, key conflicts, diffusion components and original/candidate error boundaries. No actionable findings.git diff --checkpass.Tests used synthetic arrays and bundled fixtures on macOS with Agg. The complete repository suite, documentation-site build, whole-project type checks and upstream CI were not run. Sparse/DataFrame coordinate containers are not added to the supported scope.
LLM usage
LLM or coding agent used: GPT-6 via ChatGPT and Codex CLI v0.166.0 assisted with code, tests, documentation, and review. The Codex model version used for the original implementation was not independently recorded.
If one was used, I, a human, have reviewed, understood and tested every changed line.
Closes Inconsistency of
basisargument in plotting functions #3803.Tests included.
Release notes not necessary because:
Release note included as
4494.fix.md.