Repository navigation
refactor!: remove legacy preprocessing recipes - #4493
sylvesterkaczmarek wants to merge 3 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4493 +/- ##
==========================================
- Coverage 85.13% 85.12% -0.02%
==========================================
Files 138 136 -2
Lines 12247 12205 -42
==========================================
- Hits 10427 10390 -37
+ Misses 1820 1815 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Documentation build overview
18 files changed ·
|
|
The hosted test matrix, build, pre-commit, benchmark and coverage checks are now green on head |
Refs #4433, scoped to the three legacy preprocessing recipes discussed there.
Remove
pp.recipe_seurat,pp.recipe_zheng17,pp.recipe_weinreb17and their private implementation for the planned Scanpy 2.0 cleanup. Keepexperimental.pp.recipe_pearson_residualsand the lower-level preprocessing functions unchanged.Update the live API pages, Scanorama example and PAGA tutorial to explicit preprocessing steps. A breaking-change fragment and migration guide explain default Seurat/Zheng replacements under ScanpyV1, the additional
uns["log1p"]metadata, and why Weinreb workflows do not have an exact standard-function replacement. Clear only the obsolete log output of the edited notebook cell; historical release notes remain intact.Validation
uns["log1p"]metadata difference is excluded from equivalence claims. An independent review separately passed 24 migration comparisons.Subsequent validation
The migration example now works with supported AnnData 0.12.14 as well as 0.13.4. The later focused run passed 58 tests in each environment. The broader preprocessing suite passed 766 tests, with 54 expected failures. Eight old-recipe comparisons per environment matched normalized values, gene selection and normalization factors exactly, with small documented floating-point scaling differences in some cases.
The formerly provisional release-note fragment is now docs/release-notes/4493.breaking.md. The upstream Read the Docs status succeeded on this follow-up commit. Its complete builder log was not independently inspected, and future CI reruns remain pending. Human line-by-line review of these latest changes remains pending.
LLM usage
LLM or coding agent used: GPT-6 via ChatGPT and Codex CLI v0.166.0 assisted with code, tests, documentation, and review. The Codex model version used for the original implementation was not independently recorded.
If one was used, I, a human, have reviewed, understood and tested every changed line.
Linked issue: Remove recipes #4433 (legacy recipes only).
Tests included.
Breaking-change release note and migration guide included.