Repository navigation
feat: use the modern UMAP transform pipeline in ingest - #4492
Open
sylvesterkaczmarek wants to merge 3 commits into
Open
sylvesterkaczmarek wants to merge 3 commits into
sylvesterkaczmarek wants to merge 3 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
I updated the PR to match the repository checks: a semantic title, the numbered release-note fragment, and a float32-tolerant PCA regression assertion after the minimal-dependency CI caught a 2.3e-5 roundoff difference. The production UMAP code is unchanged. Could a maintainer assign the appropriate milestone (perhaps 1.13.0) or the 'no milestone' label when convenient? The milestone check currently fails because neither is set. |
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4492 +/- ##
==========================================
- Coverage 85.13% 85.13% -0.01%
==========================================
Files 138 138
Lines 12247 12245 -2
==========================================
- Hits 10427 10425 -2
Misses 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4481.
Use UMAP 0.6's modern transform pipeline in
tl.ingest, while retaining compatibility with UMAP 0.5. Pass the reference metric parameters, neighbor count and embedding dimension before UMAP validates its state. Reuse the stored reference embedding without fitting a new UMAP model.Validation on macOS arm64 / Python 3.13:
LLM usage
LLM or coding agent used: GPT-6 via ChatGPT and Codex CLI v0.166.0 assisted with code, tests, documentation, and review. The Codex model version used for the original implementation was not independently recorded.
If one was used, I, a human, have reviewed, understood and tested every changed line.
Closes Use new umap 0.6 pipeline in
ingest#4481.Tests included.
Release notes not necessary because:
A release-note fragment is included.