[khorben]

What does this PR do?

This PR fixes two crashes when starting salt_master on NetBSD; one of the crashes is expected to affect OpenBSD as well.

What issues does this PR fix or reference?

The patch for salt/grains/core.py avoids accessing an undefined element
of the grains dictionary, on both NetBSD and OpenBSD. This matches the
corresponding code for FreeBSD.

The patch for salt/utils/network.py restricts the OS version test to the
part before "_" on NetBSD; this could raise an exception if py-packaging
wasn't aware of the suffix (e.g., "BETA" would work but "STABLE" not).

Previous Behavior

  File "/usr/pkg/lib/python3.12/site-packages/salt/loader/lazy.py", line 1302, in _run_as
    ret = _func_or_method(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/pkg/lib/python3.12/site-packages/salt/grains/core.py", line 2809, in os_data
    _osrelease_data(grains["os"], grains["osfullname"], grains["osrelease"])
                                  ~~~~~~^^^^^^^^^^^^^^
KeyError: 'osfullname'

And:

  File "/usr/pkg/lib/python3.12/site-packages/salt/utils/network.py", line 1102, in netbsd_interfaces
    if Version(os.uname()[2]) < Version("8.0"):
       ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/pkg/lib/python3.12/site-packages/packaging/version.py", line 202, in __init__
    raise InvalidVersion(f"Invalid version: {version!r}")
packaging.version.InvalidVersion: Invalid version: '10.1_STABLE'

New Behavior

Salt master starts as expected.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

[twangboy]

Could we get a changelog and a test please

[twangboy]

Consider opening this against 3006.x as the bug probably exists there.

[twangboy]

Please rebase this PR on 3006.x branch and address failing tests if any.