Repository navigation
android: report soft keyboard actions as the return key - #4801
Open
SergioRibera wants to merge 1 commit into
Open
SergioRibera wants to merge 1 commit into
SergioRibera wants to merge 1 commit into
Conversation
Contributor
|
Do we not need the actual event type? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In single-line fields
GameTextInputturns the return key of the soft keyboard into an editoraction ("Done", "Go", "Search", ...) and sends it as
InputEvent::TextAction. The backend dropsit as an unknown event, so pressing the action key does nothing: forms can't be submitted from
the keyboard.
This reports the action as a press and release of the return key, which is what the key stands
for. Applications already handle
Enterto submit a field, and there is no IME action event inwinit to report it otherwise.
InputEvent::TextActionlanded inandroid-activity0.6.1, hence the bump.changelogmodule if knowledge of this change could be valuable to users