Repository navigation
Conversation
st0012
changed the title
…pace The workspace stack lived in Context, but several places changed it directly, and each had to remember the rules itself, like keeping the home workspace and loading helper methods. That caused a bug: `pushws foo` followed by a bare `chws` stayed on `foo` instead of going back to main. - Add WorkspaceStack and make it the only place that changes the stack. - Move the workspace methods from ext/workspaces.rb and ext/change-ws.rb into Context, and delete those files. - Store from_binding on Context, so it no longer asks Irb. - Stop reading Context's instance variables from outside it. - Extract WorkSpace.base_binding from WorkSpace#initialize. - Remove dead code: Context#workspace_home, IrbLoader#old and Measure#initialize. A file loaded with `irb_load file, true` now also gets helper methods like `conf`.
st0012
force-pushed
the
claude/irb-context-workspace-coupling-no0j43
branch
from
October 8, 2026 21:06
2ebded8 to
b827bf7
Compare
st0012
marked this pull request as ready for review
October 8, 2026 21:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Irb,ContextandWorkSpacereach into each other a lot. The clearest example is the workspace stack. It lives inContext, but several places change it directly, and each one has to remember the rules itself, like keeping the home workspace and loading helper methods. Some forget.That already caused a bug:
pushws foofollowed by a barechwsstays onfooinstead of going back to main.Direction
Each class should own one thing:
WorkSpace: a binding and its main objectWorkspaceStack(new): moving between workspaces and keeping the stack's rulesContext: the session's settings and stateIrb: the loop that reads, evaluates and prints inputThis PR takes the first steps:
WorkspaceStackand make it the only place that changes the stack. This fixes thechwsbug.ext/workspaces.rbandext/change-ws.rbintoContext, and delete those files.from_bindingonContext, so it no longer asksIrb.Context's instance variables from outside it.WorkSpace.base_bindingfromWorkSpace#initialize.Behavior changes
irb_load file, truenow gets helper methods likeconfinside the loaded file. Before, this raised a NameError.irb/ext/workspacesandirb/ext/change-wsare removed. Code that still requires them will load the old copies bundled with Ruby, which breakpushws,popwsandchws, so drop those requires.Generated by Claude Code