Repository navigation
chore: add Amp orb setup script - #64
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely identifies the main change: adding an Amp orb setup script. |
| Description check | ✅ Passed | The description explains the Amp orb setup script, its dependencies, CPU-only configuration, limitations, and testing status. It is directly related to the changeset. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Autopilot is currently an internal CodeRabbit preview.
A rabbit checks the tools in place
Then readies kernels for a build
With CUDA off, the CPU waits
The setup script completes its task
And leaves the test run for another day
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
This PR adds a well-structured Amp orb setup script with proper bash safety practices (set -euo pipefail), idempotent package installation, and appropriate error handling. The script correctly handles sudo detection and package management for the CPU-only build path. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Up to standards ✅🟢 Issues
|
Adds .agents/setup for Amp orbs (Debian 12, no GPU). Installs only the toolchain pinned by CI and manifests and ends with a dependency fetch.
50128b1 to
95c194a
Compare
CodeAnt PR Risk: Low Risk
Assessed commit: |
User description
What
Adds
.agents/setup, the script Amp runs on a fresh orb before it saves the snapshot (docs). It's an executable bash script withset -euo pipefailthat runs from the repo root. It's idempotent: on a re-run, anything already installed is skipped. It installs only what this repo's CI and manifests need, and ends with a dependency fetch or prebuild, not a test run, so it stays well under the 20-minute setup limit.What it installs
Pins and notes
cmake_minimum_required(3.24)(Debian 12 has 3.25.1); CPU path-DBKL_ENABLE_CUDA=OFFand thepython3 tools/check_*.py/test_*.pychecks from ci-cpu.yml use only the orb's system python3.-DBKL_ENABLE_CUDA=ON(kernel builds, benches, compute-sanitizer) needs the self-hosted[self-hosted, Linux, X64, CUDA]runner. On an orb, only the CPU checks and docs/tools work.No GPU on orbs
Amp orbs are Debian 12 cloud VMs with no GPU. The GPU-gated parts of this repo can't run on an orb; the notes above give the CPU path.
Testing
bash -nandshellcheck0.10.0: clean.Things to double-check
~/.cargo/bin,~/.juliaup/binand~/.local/binand add those to the login profile. The script exports them for its own run. In a non-login, non-interactive shell they weren't on PATH, so check that Amp's agent shell findscargo/julia/uv.apt-getusesAcquire::Retries=5, but a deb.debian.org 500 can still fail the setup. Amp doesn't save a snapshot from a failed setup, so a retry fixes it.amp projects snapshots delete <project>to force a fresh setup, or wait for it to expire (Amp reuses a snapshot for up to 72 hours).Propose-only: please review before merging.
Summary by cubic
Adds
.agents/setup, the bash script Amp runs on a fresh orb before saving a snapshot (Debian 12, CPU only). It installs only the packages this repo's CI needs —build-essential,cmake,shellcheck— and ends with the CPU-only CMake configure (-DBKL_ENABLE_CUDA=OFF), which skips every kernel target so no nvcc is required.Written for commit 95c194a. Summary will update on new commits.
CodeAnt-AI Description
Prepare Amp orbs for CPU-based development
What Changed
Impact
✅ Ready-to-use CPU development on Amp orbs✅ CPU setup without GPU hardware✅ Repeatable orb setup💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.