Skip to content

chore: add CodeRabbit review config - #63

Merged
rmems merged 3 commits into
mainfrom
chore/coderabbit-config
Oct 24, 2026
Merged

rmems merged 3 commits into
mainfrom
chore/coderabbit-config

Conversation

@rmems

@rmems rmems commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

User description

Adds a .coderabbit.yaml for CodeRabbit reviews. This PR only adds that one file.

Baseline (same in every repo)

  • request_changes_workflow: false and fail_commit_status: false, so CodeRabbit never blocks a merge
  • Auto-review on; draft PRs skipped (auto_review.drafts: false)
  • chill review profile

Tailoring for blackwell-kernel-lab

  • Stack: CUDA C++ kernels + Python tools; CPU CI with -DBKL_ENABLE_CUDA=OFF; GPU/sanitizer jobs self-hosted and gated
  • Extra path filters: !results/**
  • Path instructions: kernels/**/*.cu, kernels/**/CMakeLists.txt, {tools,kernels/tools}/**/*.py, **/*.sh, fixtures/**, …
  • Tools: on ruff, shellcheck, actionlint, yamllint, markdownlint; off biome

Validated against CodeRabbit's schema.v2.json, with no unknown keys and every path_instructions glob matching a tracked file.


Devin Review


Summary by cubic

Adds a CodeRabbit review config so CodeRabbit can review this repo without ever blocking a merge, and treats .coderabbit.yaml as a CPU-only path so review-config changes don't schedule the self-hosted GPU runner.

  • Enables auto-review on non-draft PRs with the chill profile.
  • Avoids reviewed file noise from results/**.
  • Provides path-specific instructions for CUDA kernels, CMake, Python tools, shell scripts, fixtures, and workflows.
  • Enables ruff, shellcheck, actionlint, yamllint, and markdownlint; disables biome.

Written for commit d51cb42. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Chores
    • Added automated reviews for non-draft pull requests, with checks for Python, shell scripts, GitHub Actions, YAML, and Markdown.
    • Configured reviews to skip results files and not request changes or fail commit status.
    • Changes to the review configuration no longer trigger GPU scheduling on their own.

CodeAnt-AI Description

Enable non-blocking CodeRabbit reviews without GPU CI runs

What Changed

  • CodeRabbit automatically reviews non-draft pull requests and does not block merges.
  • Reviews skip results/** and apply repository-specific guidance and checks to relevant files.
  • Changing the review configuration no longer schedules the self-hosted GPU job.

Impact

✅ Automatic reviews on non-draft pull requests
✅ Merge checks remain unblocked by CodeRabbit
✅ Review configuration changes avoid GPU CI runs

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai

codeant-ai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Incremental review completed d51cb42 Oct 24, 2026 · 04:06 04:06
✅ Reviewed your PR aaf6ca3 Oct 01, 2026 · 00:46 00:47

@codeant-ai

codeant-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T00:48:08.648532Z aaf6ca3 PR opened
🔒 Security Review ✅ Completed 2026-10-01T00:48:35.978875Z aaf6ca3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between aaf6ca3 and d51cb42.

Files selected for processing: 3
  • .coderabbit.yaml
  • tools/check_gpu_ci_gate.py
  • tools/gpu_ci_gate.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

Adds CodeRabbit review settings, path-specific instructions, and lint-tool configuration. Updates the GPU CI gate to classify .coderabbit.yaml changes as CPU-only and tests that classification.

Changes: CodeRabbit configuration

Layer / File(s) Summary
Review behavior and tool configuration
.coderabbit.yaml
Sets review behavior and excludes results/**. Adds instructions for CUDA, Python tools, shell scripts, fixtures, and GitHub Actions. Enables Ruff, ShellCheck, actionlint, yamllint, and markdownlint; disables Biome.
CPU-only GPU gate classification
tools/gpu_ci_gate.py, tools/check_gpu_ci_gate.py
Classifies .coderabbit.yaml changes as not requiring GPU scheduling and adds a test for that classification.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • rmems/blackwell-kernel-lab#65: Both PRs update CPU-only GPU gate classification; this PR also documents Python checker commands that PR #65 adds to the CI workflow.

Suggested labels: testing

Merge Risk: Minimal · up to d51cb

The PR adds review configuration and a narrowly scoped CPU-only classification without any documented remaining merge-blocking issue.

Security architecture risk: Minimal · up to d51cb

The GPU scheduling exemption applies only to the review configuration file. GPU-relevant changes still require validation, and fork restrictions and failure handling remain unchanged. No material security risk was identified in the reviewed changes.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The scheduling change is limited to this repository's exact .coderabbit.yaml path. It does not broaden runner eligibility for other files or introduce a new tenant, credential, data-store, or environment authority.

Trust Boundaries and Controls

  • observed — Attacker-controlled PR paths are classification inputs, not authority to replace the trusted detector. Fork GPU changes remain untrusted and cannot satisfy verification even with a reported successful GPU result. The new exemption does not alter those checks.

Resilience and Maintainability Implications

  • observed — Existing terminal-state controls remain fail-closed: failed detection or invalid outputs reject verification, required GPU work must succeed, and CPU-only work must have skipped the GPU job. Failed validation publishes failure for the candidate commit; deleted pushes skip publication.
Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding the CodeRabbit review configuration.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Oct 1, 2026
@gitar-bot

gitar-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Gitar is working

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

Gitar

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a CodeRabbit configuration file for automated code reviews. The YAML structure is valid, contains no security vulnerabilities, and appears properly configured for the repository's tech stack (CUDA C++ kernels, Python tools, shell scripts, and CI workflows). The configuration appropriately enables relevant linters (ruff, shellcheck, actionlint, yamllint, markdownlint) and sets up non-blocking reviews with the "chill" profile. No merge-blocking issues identified.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@codeant-ai

codeant-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown

CodeAnt Nitpicks

1 code suggestion

1. This comment says the configuration was not pushed, but this committed file is the active repository review policy and the statement is false.

Comment mismatch · .coderabbit.yaml:2

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Devin Review

Comment thread .coderabbit.yaml Resolved
Comment thread .coderabbit.yaml Resolved
Comment thread .coderabbit.yaml Resolved
@codacy-production

codacy-production Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .coderabbit.yaml Resolved
Comment thread .coderabbit.yaml Resolved
Comment thread .coderabbit.yaml Resolved
Comment thread .coderabbit.yaml Resolved
@rmems

rmems commented Oct 1, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai Please address all of the review comments and PR comments on this PR (including Cubic's) by committing fixes to this branch. Keep request_changes_workflow: false and fail_commit_status: false, and keep the file valid against schema.v2.json.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
printf '\n=== Configuration outline ===\n'
ast-grep outline .coderabbit.yaml || true
printf '\n=== Configuration ===\n'
cat -n .coderabbit.yaml
printf '\n=== Review comments ===\n'
gh api --paginate repos/rmems/blackwell-kernel-lab/pulls/63/comments --jq '.[] | {id, user: .user.login, path, line, body, html_url, in_reply_to_id}'
printf '\n=== Reviews ===\n'
gh api --paginate repos/rmems/blackwell-kernel-lab/pulls/63/reviews --jq '.[] | {id, user: .user.login, state, body, html_url}'
printf '\n=== PR comments ===\n'
gh api --paginate repos/rmems/blackwell-kernel-lab/issues/63/comments --jq '.[] | {id, user: .user.login, body, html_url}'

Length of output: 34047


@rmems I found four distinct issues across Cubic’s, Devin’s, and CodeAnt’s comments. I’ll route the fixes through the coding workflow for commits to this PR branch.

  • Replace the stale draft header in .coderabbit.yaml.
  • Remove backticks from all path instruction values.
  • Replace the Python wildcard guidance with the actual CI commands and arguments.
  • Exclude .coderabbit.yaml from GPU change detection and add regression coverage.
  • Preserve request_changes_workflow: false and fail_commit_status: false.
  • Validate the updated configuration against schema.v2.json.

  • 📌 Create a pull request with these changes

You are interacting with an AI system.

@rmems rmems self-assigned this Oct 22, 2026
cursoragent and others added 2 commits October 24, 2026 04:03
Bring the CodeRabbit config branch up to date with main.

Co-authored-by: Raul Cardenas Montoya <montoyaraul34@gmail.com>
Drop the unpublished-draft header, remove backticks from path instructions, and name the individual hosted Python checks. Treat .coderabbit.yaml as a CPU-only path so a review-config change does not schedule the self-hosted GPU.

Co-authored-by: Raul Cardenas Montoya <montoyaraul34@gmail.com>
@codeant-ai

codeant-ai Bot commented Oct 24, 2026

Copy link
Copy Markdown

CodeAnt PR Risk: Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: d51cb42cdd15

@rmems
rmems merged commit 4ed22e7 into main Oct 24, 2026
11 checks passed
@linear-code

linear-code Bot commented Oct 24, 2026

Copy link
Copy Markdown

RM-2341

@rmems
rmems deleted the chore/coderabbit-config branch October 24, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants