Repository navigation
fix: Preserve user language and input method settings during setup - #1959
Merged
Merged
Conversation
Update only Weasel entries in the current user language list, writing it only when needed. Preserve TSF profiles during upgrades and include the helper in installer and source-build output.
…iles Replace current-user IMM entries with TSF entries at their existing position and preserve the default input method. Keep shared legacy registrations and binaries during upgrades; clean them on uninstallation after updating the current user.
Add helper unit tests and installer regression checks to the existing Windows MSBuild job. Check input method order, display language and default overrides, legacy migration, and shared IMM cleanup.
This was referenced Oct 20, 2026
Closed
Contributor
Author
|
cc @fxliang would love to get your thoughts on this when you have a moment. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing or upgrading Weasel has been observed to change the Windows display language or restore a previously removed Microsoft Pinyin input method. This PR changes how setup updates input method registration and the current user’s language list.
Microsoft documents that Windows dynamically adjusts display language and default input method settings based on the user language list, and recommends the International PowerShell cmdlets for updating these settings on a running system.
Changes:
InstallLayoutOrTipwith a PowerShell helper that reads the existing list through Get-WinUserLanguageList, modifies Weasel entries, and writes it back through Set-WinUserLanguageList. Skip writing the list when no change is needed.Add helper unit tests and installer regression tests covering input method ordering, duplicate entries, repeated execution, legacy migration, preservation of shared resources during upgrades, and uninstallation cleanup. Installer tests also check the language list, display language override, and default input method override.
Closes #1296.
Closes #1849.