Repository navigation
Conversation
Only count WeaselServer processes in the TSF client login session so another signed-in user does not prevent local service recovery. Related to rime#1533; this does not change user data directory handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a second Windows user needs to start or recover Weasel,
_EnsureServerConnected()counts everyWeaselServer.exeon the machine. A server left running in another login session therefore prevents the current session from launching its own server, even though it cannot serve that user's IPC connection.Restrict the process count to the TSF client's Windows login session using
ProcessIdToSessionId. A server in the current session still prevents a duplicate launch. The change stays inside the existing process enumeration lambda.Related to #1533. This is a partial fix for the recovery blocker, not a resolution of the whole multi-user report. It does not change user data directory selection or establish complete multi-user support.
Validation
Based on upstream
masterat82b50c9e9b9ee0bd31357db6f25ddc804546c7f7.WeaselServer.exein the current session was detected while running and no longer counted after exit.Remaining verification