Repository navigation
fix(WeaselTSF): restore UIElement updates in non-UILess mode - #1951
Merged
Merged
Conversation
Contributor
Author
|
cc @fxliang |
|
Just tested |
|
这是个不错的输入法，但愿能早日合并这个修复。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1927, UIElement updates are skipped when the normal candidate window is displayed. This regresses the behavior introduced by #1801 and prevents screen readers such as NVDA from receiving candidate updates.
_pbShowdescribes the candidate window display state and is not a reliable indicator of whether the TSF UIElement is available. Use_uiStartedto guard_UpdateUIElement()instead, so updates are sent in both UILess and normal display modes while the UIElement lifecycle is active.