Skip to content

Fix Tailwind important option being written as importants - #7573

Merged
FarhanAliRaza merged 3 commits into
reflex-dev:mainfrom
quotentiroler:fix/tailwind-important-key
Oct 22, 2026
Merged

FarhanAliRaza merged 3 commits into
reflex-dev:mainfrom
quotentiroler:fix/tailwind-important-key

Conversation

@quotentiroler

@quotentiroler quotentiroler commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)

tailwind_config_js_template wrote the important option to the generated tailwind.config.js as importants:. Tailwind only reads important, so rx.plugins.TailwindV3Plugin(config={"important": True}) (or a selector like "#app") had no effect.

This changes the key to important and adds regression tests for the boolean form, the selector form and the unset case. The tests fail on main and pass with the fix. Includes a bugfix news fragment for reflex-base.

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

View guided diff

tailwind_config_js_template emitted `importants:` in the generated
tailwind.config.js. Tailwind only reads `important`, so setting the
option on TailwindV3Plugin/TailwindV4Plugin had no effect.

Adds regression tests for the boolean and selector forms and for the
unset case.
@quotentiroler
quotentiroler requested a review from a team as a code owner October 15, 2026 08:28

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Fixes the generated Tailwind configuration so important takes effect.

  • The generated Tailwind config now uses the important key.

No actionable issues found. Tests were inspected but not run.

Reviews (3) · Last reviewed commit: "Merge branch 'main' into fix/tailwind-im..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 13 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 148 untouched benchmarks


Comparing quotentiroler:fix/tailwind-important-key (2a5c668) with main (973a524)

Open in CodSpeed

@FarhanAliRaza
FarhanAliRaza enabled auto-merge (squash) October 19, 2026 09:18
@masenf masenf added the on deck PRs lined up to review / merge next label Oct 22, 2026

@masenf masenf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@FarhanAliRaza
FarhanAliRaza merged commit c66605e into reflex-dev:main Oct 22, 2026
166 of 169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on deck PRs lined up to review / merge next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants