Repository navigation
fix(events): cancel disconnected page-load chains - #7415
Merged
FarhanAliRaza merged 6 commits intoOct 22, 2026
Merged
FarhanAliRaza merged 6 commits into
FarhanAliRaza merged 6 commits into
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issue was found. SummaryCancels unfinished hydration and page-load chains when their current client disconnects.
Reviews (6) · Last reviewed commit: "Merge branch 'main' into fix/7251-cancel..." · Reviewed by Greptile |
Merging this PR will not alter performance1 warning
Comparing |
FarhanAliRaza
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page-load handlers keep running after their client disconnects, retaining state locks and repeatedly trying to send updates to a closed socket. Cancel that work when the current socket disconnects.
Closes #7251.
What changed
Verification
pyright reflex testsand changed-file pre-commit hooks passed.Deployment notes
No configuration changes. Page-load handlers and their chained events now receive cancellation on disconnect, matching navigation and reconnect behavior. Existing Redis cancellation-persistence behavior is unchanged and tracked separately in #7248.