Repository navigation
Sync python-selenium with the updated tutorial - #878
Merged
martin-martin merged 2 commits intoOct 8, 2026
Merged
martin-martin merged 2 commits into
martin-martin merged 2 commits into
Conversation
…tion With Python and Selenium Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Point track locators at the new card markup (a.stretch-link, div.title, div.attribution-meta, div.info-pill) - Use div.cookie-control for the cookie consent dialog - Wait for #view-more to be clickable before clicking it in observation.py - Drop the implicit wait from the page-object base class - Pin selenium==4.50.0 in pyproject.toml and refresh the README Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
martin-martin
deleted the
maintenance/modern-web-automation-with-python-and-selenium-20261008
branch
October 8, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins
python-selenium/requirements.txt(and refreshesuv.lock) to match the tutorial's maintenance update, which bumps the tested-with Selenium pin from 4.48.0 to 4.50.0 (current PyPI release). The previous materials pins wereselenium==4.29.0. Transitive dependencies are re-pinned to their current releases (attrs 26.1.0, certifi 2026.7.22, h11 0.16.0, idna 3.20, trio 0.34.0, typing-extensions 4.16.0, urllib3 2.8.0, websocket-client 1.9.2, wsproto 1.3.2). No code changes.Verification
pip install -r requirements.txt .: everybandcampmodule imports cleanly on Selenium 4.50.0.training/navigation.pyruns green with headless Firefox (Selenium Manager fetched the browser and driver).uvx ruff@0.14.1 format --checkandruff checkpass.training/interaction.pyandobservation.py(#view-morecould not be scrolled into view) and thediscoverapp (div.meta p anot found) fail identically on the old 4.29.0 pins. The cause is live Bandcamp DOM drift, which needs a separate code update.communication.pyneeds a display (non-headless), so it couldn't run on the CI box.Update: locator fix for Bandcamp's redesign (commit 0d022d2)
The DOM drift noted above is now fixed, matching the full update of the article draft:
locators.py: track locators point at the new card markup (a.stretch-link,div.title,div.attribution-meta,div.info-pill), and the cookie dialog usesdiv.cookie-control.training/navigation.py,communication.py,observation.py: same locator changes.observation.pynow waits for#view-moreto be clickable before clicking, because the closing cookie dialog otherwise races the click.base.py: drops the implicit wait, so the page objects use explicit waits only.pyproject.tomlpinsselenium==4.50.0, and the README uses thediscovercommand and mentions Selenium Manager.Verified on Python 3.14.6, Selenium 4.50.0, Firefox 157.0.1, and geckodriver 0.37.1: the training scripts and the
discoverapp (tracks, play, pause, more, exit) all run against the live site.ruff format --checkandruff checkpass.🤖 Generated with Claude Code