Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
Author
|
The build_android failure isn't from this change. It also fails on main since the Kotlin 2.3.21 update (#59535): |
Contributor
|
/rebase |
cortinico
requested changes
Oct 29, 2026
| * Whether to pass `--reset-cache` to the [bundleCommand]. Disable it to keep the Metro cache | ||
| * between release builds. Default: true | ||
| */ | ||
| val resetCache: Property<Boolean> = objects.property(Boolean::class.java).convention(true) |
Contributor
There was a problem hiding this comment.
Name is too generic. resetCache can mean a bunch of things for react native. This should be more specific
lazerg
force-pushed
the
fix/issue-59543-release-bundle-reset-cache
branch
from
October 30, 2026 01:00
c4fb600 to
00b4873
Compare
Contributor
Author
|
Renamed it to |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
BundleHermesCTaskalways passes--reset-cacheto the bundle command, and nothing in thereact {}block can turn it off. Metro's default cache lives inos.tmpdir()/metro-cache, which every Metro on the machine shares. So each Android release bundle wipes the cache of other projects and dev servers, and on Windows it can fail withENOTEMPTYwhen another Metro writes into that folder during the reset.This adds a
resetCacheproperty to thereact {}extension. It defaults totrue, so builds work as before, andresetCache = falsedrops the flag from the bundle command.Fixes #59543
Changelog:
[ANDROID] [ADDED] - Add
resetCacheto thereact {}Gradle extension to let release bundles keep the Metro cacheTest Plan:
Added
getBundleCommand_withResetCacheDisabled_returnsCommandWithoutResetCachetoBundleHermesCTaskTest, and the existing command tests still expect--reset-cacheby default../gradlew :react-native-gradle-plugin:test --tests 'com.facebook.react.tasks.BundleHermesCTaskTest'passes (17 tests), and ktfmt is clean on the changed files.