[lazerg]

Summary:

BundleHermesCTask always passes --reset-cache to the bundle command, and there is no way to turn it off. Metro's default cache lives in os.tmpdir()/metro-cache, which every Metro on the machine shares. So each Android release bundle wipes the cache of other projects and dev servers, and on Windows it can fail with ENOTEMPTY when another Metro writes into that folder during the reset.

This adds a react.resetMetroCacheBeforeBundling Gradle property, with resetMetroCacheBeforeBundling as the unscoped name. It defaults to true, so builds work as before. Set react.resetMetroCacheBeforeBundling=false in gradle.properties to drop the flag from the bundle command. If both names are set, the scoped one wins, as with react.includeJitpackRepository.

Fixes #59543

Changelog:

[ANDROID] [ADDED] - Add react.resetMetroCacheBeforeBundling (or resetMetroCacheBeforeBundling) Gradle property to let release bundles keep the Metro cache

Test Plan:

Added ProjectUtilsTest cases for both property names (default, true, false, invalid value, and both set) and getBundleCommand_withResetMetroCacheBeforeBundlingDisabled_returnsCommandWithoutResetCache to BundleHermesCTaskTest. The existing command tests still expect --reset-cache by default. ./gradlew :react-native-gradle-plugin:test passes for both classes, and ktfmt is clean on the changed files.

[lazerg]

The build_android failure isn't from this change. It also fails on main since the Kotlin 2.3.21 update (#59535): :gradle-plugin:shared:compileKotlin warns that API version 2.0 is deprecated, and -Werror turns that warning into an error.

[cortinico]

/rebase

[cortinico]

Name is too generic. resetCache can mean a bunch of things for react native. This should be more specific

[lazerg]

Renamed it to resetMetroCache and rebased onto main.

[cortinico]

Renamed it to resetMetroCache and rebased onto main.

I think this should be called something like resetMetroCacheBeforeBundling or resetMetroCacheOnReleaseBuilds or so.

I would also suggest that we don't create a new entry in the ReactExtension but instead use a gradle property like react.resetMetroCacheBeforeBundling=false that you can put in your gradle.properties file

[lazerg]

I dropped the react {} option and moved this to a react.resetMetroCacheBeforeBundling Gradle property in 9197654. It defaults to true, so react.resetMetroCacheBeforeBundling=false in gradle.properties turns the reset off.

[cortinico]

This should follow the convention in this file. You sould accept both a SCOPED_ version of this property with react.resetMetroCacheBeforeBundling and an unscoped one with resetMetroCacheBeforeBundling

[lazerg]

Done in c50219c. It now reads both react.resetMetroCacheBeforeBundling and resetMetroCacheBeforeBundling. If both are set, the scoped one wins, same as includeJitpackRepository.

[meta-codesync]

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D128660659.