Repository navigation
fix(store): admin org search and kyc list skip soft-deleted orgs - #1974
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
Coverage Report for CI Build 38363645868Coverage increased (+0.1%) to 54.857%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Billing account and subscription deletes become soft in #1983, and this search is the last billing list that doesn't skip deleted rows. So a live org can show a deleted account's plan and payment mode, for example after an org delete that stops half way. Can we add The kyc join is fine as of now, since the kyc delete still removes the row. The kyc row should also move to soft delete, like the other tables the org delete touches. Can we do that, and add |
0789141 to
1155d62
Compare
|
Done in 1155d62. The billing account and subscription joins now check |
1155d62 to
8ced8e5
Compare
8ced8e5 to
2b47e3b
Compare
2b47e3b to
7c6880e
Compare
What changes
Why
These queries read straight from
organizationsand the billing tables with no live filter. Once the org delete is soft, a deleted org or a deleted account would still show up. The billing part matters once the billing deletes become soft in #1983.Stack
This PR is stacked on #1984 (kyc row soft delete). Merge #1984 first.
Tests