Repository navigation
Bump redex-pict-lib version after new redex/pict exports - #277
Closed
turinglambdaai wants to merge 1 commit into
Closed
turinglambdaai wants to merge 1 commit into
turinglambdaai wants to merge 1 commit into
Conversation
Commits 2026-08-10 ("add judgment-form-no-bar-when-no-premises") and
2026-08-21 ("add premise-spacing") added new bindings to redex/pict
without bumping the redex-pict-lib version, which stays at "1.10" —
the same version as the last released snapshot. Packages that need
the new exports cannot declare that requirement: e.g. plmw-2026
currently pins redex-lib at 1.23 as a proxy, which both fails on
released Rackets and does not actually guarantee that the pict
bindings are present.
Bump to "1.11" so that (["redex-pict-lib" #:version "1.11"])
expresses the real requirement.
Member
|
redex-pict-lib's version was incremented to 1.10 on August 24th in commit |
Author
|
You're right, and thank you for the correction — I checked that master's version matched the release, but never looked at the timeline of the bump commit itself. Closing was the right call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two recent commits added new bindings to
redex/pictwithout bumping theredex-pict-libpackage version, which is still"1.10"— the same version the last release shipped:So there is currently no way for a package to declare "I need the pict library with those bindings": the version on
masteris indistinguishable from the released one. A concrete victim isplmw-2026, which uses both new bindings and currently pinsredex-libat"1.23"as a proxy — that pin fails on every released Racket (release catalogs shipredex-lib1.21) and still does not actually guarantee the pict bindings are present, since the pict library is a separate package.Bumping to
"1.11"lets packages express the real requirement as["redex-pict-lib" #:version "1.11"]. I have verified locally that, with this bump applied tomaster,plmw-2026(with its dependency declaration fixed to use that pin, plus the missingrhombus-slideshow-libdependency) installs and compiles cleanly both againstmasterredex-lib and against the releasedredex-lib1.21.