Repository navigation
gh-159130: _remote_debugging: Do not return another thread when the selected thread is filtered out - #159132
Open
maurycy wants to merge 6 commits into
Open
gh-159130: _remote_debugging: Do not return another thread when the selected thread is filtered out#159132maurycy wants to merge 6 commits into
_remote_debugging: Do not return another thread when the selected thread is filtered out#159132maurycy wants to merge 6 commits into
Conversation
_remote_debugging: Don't replace a filtered thread with the next one_remote_debugging: Don't replace a filtered out thread with the next one
_remote_debugging: Don't replace a filtered out thread with the next one_remote_debugging: only_active_thread=True can return a different thread after mode filtering
_remote_debugging: only_active_thread=True can return a different thread after mode filtering_remote_debugging: Do not return another thread when the selected thread is filtered out
maurycy
commented
Oct 10, 2026
| goto exit; | ||
| } | ||
| // Thread was skipped due to mode filtering, continue to next thread | ||
| if (self->tstate_addr || self->only_active_thread) { |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| if (self->tstate_addr || self->only_active_thread) { | |
| if (self->only_active_thread) { |
I think this could be sufficient but I kept this the same as this condition for symmetry:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #159130 for more details.
Repro no longer holds:
_remote_debugging:only_active_thread=Truecan return a different thread after mode filtering #159130