Repository navigation
Preserve numeric zero in named URI parameters - #159
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Numeric zero was treated as an empty value in query and semicolon expansions. Keep its quoted text so offset=0 stays in the expanded URI.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
expand("{?offset}", offset=0)currently returns?offset=. Semicolon expansion also drops=0.Quote scalar values before checking emptiness so integer, float and complex zero keep their text.
Empty strings and undefined variables keep their existing behavior.
Added 24 zero cases across
?,∧, plus empty string andNonechecks.All 24 cases fail against the unchanged base.
Tox passes 60 tests on CPython 3.9 to 3.14 and PyPy 3.11.
tox -e pep8,pre-commitalso passes. The source archive and wheel build successfully and passtwine check.