Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a frame has a nonzero
pad_lengthwithout thePADDEDflag, its serializer still appends zero bytes. A peer treats those bytes as application data or part of the header block, and a DATA frame's wire length no longer matchesflow_controlled_length. ClearingPADDEDon an already configured frame triggers the same behavior.Only append the padding bytes when
PADDEDis set, matching the existing condition for the pad-length field. This covers DATA, HEADERS, and PUSH_PROMISE; the configured length remains available when the flag is enabled again.The regression covers all three frame types, zero/one/maximum padding lengths, initial unpadded construction and clearing the flag, HEADERS priority data, and re-enabling padding. Twelve cases fail against the original source. The full suite (including the HTTP/2 frame test collection) passes 166 tests with 100% statement/branch coverage. Source Ruff, strict mypy, check-manifest, wheel/sdist builds, Twine checks, and the HTML documentation build pass on Python 3.12.2.