Skip to content

Preserve pending table resize after repeated size assignment #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhgffy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve pending table resize after repeated size assignment #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/hpack/hpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,9 @@ def header_table_size(self) -> int:

@header_table_size.setter
def header_table_size(self, value: int) -> None:
self.header_table.maxsize = value
if self.header_table.resized:
# 2026-10-11: Preserve an earlier resize until its update is emitted.
if value != self.header_table.maxsize:
self.header_table.maxsize = value
self.table_size_changes.append(value)

def encode(self,
Expand Down
19 changes: 19 additions & 0 deletions tests/test_hpack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,25 @@ def test_resizing_header_table_to_same_size_ignored(self):
out = e.encode(header_set, huffman=True)
assert out == b'\x3F\x09\x3F\x45\x3F\x09\x82'

@pytest.mark.parametrize("sizes", [(0,), (128,), (0, 4096)])
def test_repeated_table_size_preserves_pending_updates(self, sizes):
# 2026-10-11: A no-op assignment must not suppress pending wire updates.
e = Encoder()
d = Decoder()
header_set = [('custom-key', 'custom-value')]
assert d.decode(e.encode(header_set)) == header_set

for size in sizes:
e.header_table_size = size
e.header_table_size = sizes[-1]
d.max_allowed_table_size = sizes[-1]

assert d.decode(e.encode([])) == []
assert d.header_table_size == sizes[-1]
assert list(d.header_table.dynamic_entries) == list(e.header_table.dynamic_entries)
assert d.decode(e.encode(header_set)) == header_set
assert e.encode([(':method', 'GET')]) == b'\x82'

def test_resizing_header_table_sends_context_update(self):
e = Encoder()

Expand Down