Repository navigation
Preserve flow-control windows when rejecting local increments - #1335
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowManager.window_opened()updates the window before checking its upper bound. A rejected localH2Connection.increment_flow_control_window()therefore leaves the window above the limit even though no WINDOW_UPDATE was emitted. A subsequent valid increment then also fails.Check the proposed size before assigning it. Add public-API regressions for both connection and stream windows, including a valid update after the rejected one. The limit and exception type are unchanged; this concerns local API rejection, not the separate inbound WINDOW_UPDATE handling.
Validation on Windows CPython 3.12:
The all-version tox matrix and Linux h2spec were not run locally. AI-assisted implementation, independently exercised against the unchanged baseline.