Repository navigation
Send the CSOM User-Agent header once - #1302
Merged
Merged
Conversation
HttpWebRequest keeps UserAgent inside its Headers collection, so the header copy loop in HttpClientSPWebRequestExecutor already moves it onto the HttpRequestMessage. The separate ParseAdd then appended the same value a second time, and every CSOM request sent through HttpClientWebRequestExecutorFactory carried a doubled User-Agent. Microsoft's throttling guidance expects a single ISV|Company|App/Version value, so a doubled value may not count as decorated traffic. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
YifengMao
approved these changes
Oct 27, 2026
YifengMao
left a comment
YifengMao
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: removes the duplicate User-Agent insertion and adds a focused regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send the CSOM User-Agent header once
Fixes #1301
CSOM requests sent through
HttpClientWebRequestExecutorFactorycarry the User-Agent value twice:Microsoft's throttling guidance asks applications to send a single
ISV|Company|App/Versionvalue. A doubled value may not count as decorated traffic.Cause
HttpClientSPWebRequestExecutor.ExecuteImplementationcopies every header fromHttpWebRequest.Headers, and then addsHttpWebRequest.UserAgentagain withParseAdd.HttpWebRequest.UserAgentis stored inHeaders, so the loop already copies it.Changes
ParseAddofUser-AgentinHttpClientSPWebRequestExecutor.ExecuteImplementation.Headers.Addin the copy loop uses the same parser and throws the sameFormatExceptionon an invalid value.Isolated/Http/HttpClientWebRequestExecutorFactoryTests. It sends a request through the factory with a capturingHttpMessageHandler, and asserts thatUser-Agentappears once and that other request headers are still copied. It needs no tenant.